Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Cache macaroon parse and validation #2320
Conversation
Some checks were not successful
Sytest Dendron (Commit)
— Build #2400 origin/erikj/cache_macaroon_parse failed in 8 min 24 sec
continuous-integration/travis-ci/pr
— The Travis CI build could not complete due to an error
Sytest Postgres (Commit)
— Build #3236 origin/erikj/cache_macaroon_parse succeeded in 9 min 23 sec
Sytest SQLite (Commit)
— Build #3320 origin/erikj/cache_macaroon_parse succeeded in 6 min 5 sec
erikjohnston
assigned
NegativeMjark
Jun 29, 2017
erikjohnston
merged commit d800ab2
into
develop
Jun 29, 2017
5 of 6 checks passed
Sytest Dendron (Commit)
Build #2400 origin/erikj/cache_macaroon_parse failed in 8 min 24 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #3236 origin/erikj/cache_macaroon_parse succeeded in 9 min 23 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #3320 origin/erikj/cache_macaroon_parse succeeded in 6 min 5 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
erikjohnston
deleted the
erikj/cache_macaroon_parse
branch
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedJun 29, 2017
Turns out this can be quite expensive for requests, and is easily
cachable. We don't cache the lookup to the DB so invalidation still
works.