/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix caching error in the push evaluator #2332

Merged
merged 1 commit into from Jul 5, 2017

Conversation

Reviewers
No reviews
Assignees

@erikjohnston erikjohnston

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richvdh @erikjohnston
@richvdh
Member

richvdh commented Jul 4, 2017

Initialising result to {} in the parameters meant that every call to
_flatten_dict used the same target dictionary.

I'm hopeful this will fix #2270,
but I suspect it won't. (This code seems to have been here since forever,
unlike the bug, and I don't really think it explains the observed
behaviour). Still, it makes it hard to investigate the problem.
@richvdh
Fix caching error in the push evaluator 
Initialising `result` to `{}` in the parameters meant that every call to
_flatten_dict used the *same* target dictionary.

I'm hopeful this will fix #2270,
but I suspect it won't. (This code seems to have been here since forever,
unlike the bug, and I don't really think it explains the observed
behaviour). Still, it makes it hard to investigate the problem.

Some checks were not successful

3 errored and 5 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #2414 origin/rav/fix_pushes failed in 6 min 20 sec
Details
@matrixbot
Sytest Postgres (Commit) — Build #3250 origin/rav/fix_pushes failed in 8 min 51 sec
Details
@matrixbot
Sytest SQLite (Commit) — Build #3334 origin/rav/fix_pushes failed in 1 min 41 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
73cfe48

@richvdh richvdh assigned erikjohnston Jul 4, 2017

@erikjohnston
Owner

erikjohnston commented Jul 5, 2017

I hate python so much.

LGTM

@richvdh richvdh merged commit 3d31b39 into develop Jul 5, 2017
5 of 8 checks passed

5 of 8 checks passed

Sytest Dendron (Commit) Build #2414 origin/rav/fix_pushes failed in 6 min 20 sec
Details
Sytest Postgres (Commit) Build #3250 origin/rav/fix_pushes failed in 8 min 51 sec
Details
Sytest SQLite (Commit) Build #3334 origin/rav/fix_pushes failed in 1 min 41 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/fix_pushes branch Jul 5, 2017

@richvdh richvdh referenced this pull request Jul 5, 2017

Closed

Badges for rooms without notifications #2270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment