Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fix bug where pusherpool didn't start and broke some rooms #2342
Conversation
All checks have passed
Sytest Dendron (Commit)
— Build #2425 origin/erikj/pusher_pool_instantiate succeeded in 8 min 30 sec
Sytest Postgres (Commit)
— Build #3261 origin/erikj/pusher_pool_instantiate succeeded in 9 min 15 sec
Sytest SQLite (Commit)
— Build #3345 origin/erikj/pusher_pool_instantiate succeeded in 5 min 40 sec
erikjohnston
assigned
NegativeMjark
Jul 6, 2017
erikjohnston
merged commit 58dc1f2
into
develop
Jul 6, 2017
7 of 8 checks passed
Sytest Postgres (Merged PR)
Build started sha1 is merged.
Details
Sytest Dendron (Commit)
Build #2425 origin/erikj/pusher_pool_instantiate succeeded in 8 min 30 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #3261 origin/erikj/pusher_pool_instantiate succeeded in 9 min 15 sec
Details
Sytest SQLite (Commit)
Build #3345 origin/erikj/pusher_pool_instantiate succeeded in 5 min 40 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
erikjohnston
deleted the
erikj/pusher_pool_instantiate
branch
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedJul 6, 2017
Since we didn't instansiate the PusherPool at start time it could fail
at run time, which it did for some users.
This may or may not fix things for those users, but it should happen at
start time and stop the server from starting.