/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add more metrics to push rule evaluation #2366

Merged
merged 1 commit into from Jul 14, 2017

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Jul 13, 2017

No description provided.

@erikjohnston erikjohnston assigned NegativeMjark Jul 13, 2017

synapse/push/bulk_push_rule_evaluator.py
+ )
+
+ self.room_push_rule_cache_metrics = register_cache(
+ "room_push_rule_cache", size_callback=lambda: self._get_rules_for_room.cache
@NegativeMjark

NegativeMjark Jul 13, 2017

Contributor

Umm, shouldn't this be size_callback=_size_calback ?

synapse/push/bulk_push_rule_evaluator.py
defer.returnValue(self.rules_by_user)
+ self.self.room_push_rule_cache_metrics.inc_misses()
@NegativeMjark

NegativeMjark Jul 13, 2017

Contributor

Umm, self.self?

@erikjohnston
Owner

erikjohnston commented Jul 13, 2017

I think I've uncranked myself now....
@erikjohnston
Add more metrics to push rule evaluation

Some checks were not successful

1 errored, 1 failing, and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #2466 origin/erikj/push_metrics failed in 18 min
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #3302 origin/erikj/push_metrics succeeded in 6 min 58 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #3394 origin/erikj/push_metrics succeeded in 1 min 36 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
8d26385

@erikjohnston erikjohnston merged commit d386281 into develop Jul 14, 2017
6 of 8 checks passed

6 of 8 checks passed

Sytest Dendron (Commit) Build #2466 origin/erikj/push_metrics failed in 18 min
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #3302 origin/erikj/push_metrics succeeded in 6 min 58 sec
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #3394 origin/erikj/push_metrics succeeded in 1 min 36 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/push_metrics branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment