/synapse

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix port script for user directory tables #2375

Merged
merged 2 commits into from Jul 20, 2017
+19 −0

Conversation

Reviewers

@NegativeMjark NegativeMjark

Assignees

@NegativeMjark NegativeMjark

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@erikjohnston @NegativeMjark
@erikjohnston
Owner

erikjohnston commented Jul 20, 2017

No description provided.

@erikjohnston
Fix port script for user directory tables

Some checks were not successful

1 errored, 1 failing, and 6 successful checks
@matrixbot
Sytest Dendron (Commit) — Build #2486 origin/erikj/port_script failed in 8 min 1 sec
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Commit) — Build #3320 origin/erikj/port_script succeeded in 7 min 7 sec
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Commit) — Build #3414 origin/erikj/port_script succeeded in 7 min 16 sec
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
d7d2475

@erikjohnston erikjohnston assigned NegativeMjark Jul 20, 2017

@NegativeMjark

NegativeMjark approved these changes Jul 20, 2017
View changes

LGTM?

scripts/synapse_port_db
+ return
+
+ if table == "user_directory_stream_pos":
+ # We need to make sure there is a single row, `(X, null)`
@NegativeMjark

NegativeMjark Jul 20, 2017

Contributor

Why do we need a single row OOI? (It might be helpful to say here in the comment)

@erikjohnston
Extend comment

Some checks were not successful

1 errored, 1 failing, and 3 successful checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
@matrixbot
Sytest Dendron (Merged PR) — Build finished.
Details
@matrixbot
Sytest Postgres (Merged PR) — Build finished.
Details
@matrixbot
Sytest SQLite (Merged PR) — Build finished.
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
60a9a49

@erikjohnston erikjohnston merged commit b274297 into develop Jul 20, 2017
0 of 3 checks passed

0 of 3 checks passed

Sytest Dendron (Merged PR) Build triggered. sha1 is merged.
Details
Sytest Postgres (Merged PR) Build triggered. sha1 is merged.
Details
Sytest SQLite (Merged PR) Build triggered. sha1 is merged.
Details

@krombel krombel referenced this pull request Aug 11, 2017

Closed

synapse_port_db is completely broken by the new user_directory_search table #2287

spantaleev added a commit to spantaleev/matrix-docker-ansible-deploy that referenced this pull request Oct 14, 2017

@spantaleev
Stop using patched synapse_port_db script 
The non-working script is supposed to be fixed
by matrix-org/synapse#2375

To have it work, we'd need an updated Docker image
of `silviof/matrix-riot-docker:latest`, which is not yet available
at the time of this commit.

Still, the previous patched synapse_port_db didn't work well either,
so it's not like we're regressing much by getting rid of it.
1c2d59a

@erikjohnston erikjohnston deleted the erikj/port_script branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment