Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add update group profile API #2377
+55
−0
Conversation
Some checks were not successful
Sytest Dendron (Commit)
— Build #2485 origin/erikj/group_profile_update succeeded in 9 min 0 sec
Sytest Postgres (Commit)
— Build #3319 origin/erikj/group_profile_update succeeded in 7 min 57 sec
Sytest SQLite (Commit)
— Build #3413 origin/erikj/group_profile_update succeeded in 7 min 9 sec
erikjohnston
assigned
NegativeMjark
Jul 20, 2017
| + "group_id": group_id, | ||
| + }, | ||
| + updatevalues=profile, | ||
| + desc="create_group", |
| + for keyname in ("name", "avatar_url", "short_description", | ||
| + "long_description"): | ||
| + if keyname in content: | ||
| + profile[keyname] = content[keyname] |
NegativeMjark
Jul 20, 2017
Contributor
Maybe check that the values are "strings" otherwise postgresql might become sad when we try to insert them, and sqlite will probably do weird things.
erikjohnston
added some commits
Jul 20, 2017
Some checks were not successful
Sytest Dendron (Commit)
— Build #2489 origin/erikj/group_profile_update failed in 7 min 40 sec
Sytest Postgres (Commit)
— Build #3324 origin/erikj/group_profile_update succeeded in 9 min 19 sec
Sytest SQLite (Commit)
— Build #3418 origin/erikj/group_profile_update succeeded in 1 min 37 sec
dbkr
requested changes
Jul 20, 2017
Could also update the comment on GroupServlet to get/set if we're being picky
| @@ -342,6 +342,25 @@ def get_group_profile(self, group_id, requester_user_id): | ||
| raise SynapseError(404, "Unknown group") | ||
| @defer.inlineCallbacks | ||
| + def update_group_profile(self, group_id, requester_user_id, content): |
Some checks were not successful
Sytest Dendron (Commit)
— Build #2495 origin/erikj/group_profile_update failed in 9 min 52 sec
Sytest SQLite (Commit)
— Build #3424 origin/erikj/group_profile_update succeeded in 1 min 47 sec
erikjohnston
merged commit 0401604
into
erikj/groups_merged
Jul 20, 2017
1 of 7 checks passed
Sytest Dendron (Commit)
Build #2495 origin/erikj/group_profile_update in progress...
Details
Sytest Dendron (Merged PR)
Build started sha1 is merged.
Details
Sytest Postgres (Merged PR)
Build started sha1 is merged.
Details
Sytest SQLite (Merged PR)
Build started sha1 is merged.
Details
continuous-integration/travis-ci/pr
The Travis CI build is in progress
Details
continuous-integration/travis-ci/push
The Travis CI build is in progress
Details
Sytest SQLite (Commit)
Build #3424 origin/erikj/group_profile_update succeeded in 1 min 47 sec
Details
erikjohnston
deleted the
erikj/group_profile_update
branch
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedJul 20, 2017
No description provided.