Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add ability to publicise group membership #2410

Merged
merged 5 commits into from Aug 21, 2017

Conversation

Projects
None yet
2 participants
Owner

erikjohnston commented Aug 11, 2017

No description provided.

erikjohnston added some commits Aug 8, 2017

Owner

erikjohnston commented Aug 11, 2017

@matrixbot retest this please

Owner

erikjohnston commented Aug 11, 2017

@matrixbot retest this please

@@ -150,6 +150,7 @@ CREATE TABLE local_group_membership (
user_id TEXT NOT NULL,
is_admin BOOLEAN NOT NULL,
membership TEXT NOT NULL,
+ is_publicised TEXT NOT NULL, -- if the user is publicising their membership
@NegativeMjark

NegativeMjark Aug 21, 2017

Contributor

Why is this a TEXT column?

Contributor

NegativeMjark commented Aug 21, 2017

Other than the schema oddities it looks good to me?

Owner

erikjohnston commented Aug 21, 2017

@matrixbot retest this please

Owner

erikjohnston commented Aug 21, 2017

@matrixbot retest this please

Owner

erikjohnston commented Aug 21, 2017

@matrixbot retest this please

Owner

erikjohnston commented Aug 21, 2017

@matrixbot retest this please

@erikjohnston erikjohnston merged commit 2800983 into erikj/groups_merged Aug 21, 2017

6 of 8 checks passed

Sytest Dendron (Commit) Build #2530 origin/erikj/groups_publicise failed in 3 min 28 sec
Details
Sytest Dendron (Merged PR) Build finished.
Details
Sytest Postgres (Commit) Build #3365 origin/erikj/groups_publicise succeeded in 10 min
Details
Sytest Postgres (Merged PR) Build finished.
Details
Sytest SQLite (Commit) Build #3459 origin/erikj/groups_publicise succeeded in 2 min 15 sec
Details
Sytest SQLite (Merged PR) Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/groups_publicise branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment