Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Send down device list change notif when member leaves/rejoins room #2443
Conversation
Some checks were not successful
Sytest Dendron (Commit)
— Build #2562 origin/erikj/rejoin_device_lists failed in 4 min 8 sec
Sytest Postgres (Commit)
— Build #3394 origin/erikj/rejoin_device_lists succeeded in 3 min 45 sec
Sytest SQLite (Commit)
— Build #3487 origin/erikj/rejoin_device_lists succeeded in 2 min 44 sec
| - defer.returnValue((newly_joined_rooms, newly_joined_users)) | ||
| + newly_left_users -= newly_joined_users |
richvdh
Sep 8, 2017
Member
this looks dodge. What happens if the user joined and then left? they appear in newly_joined and not newly_left?
erikjohnston
added some commits
Sep 8, 2017
Some checks were not successful
Sytest Dendron (Commit)
— Build #2563 origin/erikj/rejoin_device_lists failed in 4 min 0 sec
Sytest Postgres (Commit)
— Build #3395 origin/erikj/rejoin_device_lists succeeded in 3 min 54 sec
Sytest SQLite (Commit)
— Build #3488 origin/erikj/rejoin_device_lists succeeded in 2 min 22 sec
Some checks were not successful
Sytest Dendron (Commit)
— Build #2565 origin/erikj/rejoin_device_lists succeeded in 5 min 7 sec
Sytest Postgres (Commit)
— Build #3397 origin/erikj/rejoin_device_lists succeeded in 3 min 45 sec
Sytest SQLite (Commit)
— Build #3490 origin/erikj/rejoin_device_lists succeeded in 2 min 56 sec
Some checks were not successful
Sytest Dendron (Commit)
— Build #2566 origin/erikj/rejoin_device_lists failed in 5 min 15 sec
Sytest Postgres (Commit)
— Build #3398 origin/erikj/rejoin_device_lists succeeded in 3 min 41 sec
Some checks were not successful
Sytest Dendron (Commit)
— Build #2567 origin/erikj/rejoin_device_lists failed in 5 min 9 sec
Sytest Postgres (Commit)
— Build #3399 origin/erikj/rejoin_device_lists succeeded in 4 min 38 sec
Sytest SQLite (Commit)
— Build #3492 origin/erikj/rejoin_device_lists succeeded in 3 min 1 sec
Some checks were not successful
Sytest Dendron (Commit)
— Build #2568 origin/erikj/rejoin_device_lists failed in 5 min 7 sec
Sytest Postgres (Commit)
— Build #3400 origin/erikj/rejoin_device_lists succeeded in 4 min 37 sec
Sytest SQLite (Commit)
— Build #3493 origin/erikj/rejoin_device_lists succeeded in 2 min 52 sec
Some checks were not successful
Sytest Dendron (Commit)
— Build #2569 origin/erikj/rejoin_device_lists failed in 4 min 34 sec
Sytest Postgres (Commit)
— Build #3401 origin/erikj/rejoin_device_lists succeeded in 3 min 59 sec
Sytest SQLite (Commit)
— Build #3494 origin/erikj/rejoin_device_lists succeeded in 2 min 51 sec
erikjohnston
assigned
NegativeMjark
Sep 15, 2017
erikjohnston
merged commit 993d3f7
into
develop
Sep 18, 2017
6 of 8 checks passed
Sytest Dendron (Commit)
Build #2569 origin/erikj/rejoin_device_lists failed in 4 min 34 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #3401 origin/erikj/rejoin_device_lists succeeded in 3 min 59 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #3494 origin/erikj/rejoin_device_lists succeeded in 2 min 51 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
richvdh
referenced this pull request
in vector-im/riot-web
Sep 18, 2017
Closed
Stale device lists when users re-join e2e rooms #4983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedSep 7, 2017
No description provided.