Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Correctly handle leaving room in /key/changes #2449
Conversation
Some checks were not successful
Sytest Dendron (Commit)
— Build #2571 origin/erikj/rejoin_device_lists succeeded in 4 min 36 sec
Sytest Postgres (Commit)
— Build #3403 origin/erikj/rejoin_device_lists succeeded in 4 min 7 sec
Sytest SQLite (Commit)
— Build #3496 origin/erikj/rejoin_device_lists succeeded in 2 min 56 sec
erikjohnston
assigned
NegativeMjark
Sep 18, 2017
NegativeMjark
approved these changes
Sep 18, 2017
I'm not sure I understand what either version of the code is doing, but I guess this version is better in some way?
erikjohnston
merged commit 2d9f341
into
develop
Sep 18, 2017
7 of 8 checks passed
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Dendron (Commit)
Build #2571 origin/erikj/rejoin_device_lists succeeded in 4 min 36 sec
Details
Sytest Postgres (Commit)
Build #3403 origin/erikj/rejoin_device_lists succeeded in 4 min 7 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #3496 origin/erikj/rejoin_device_lists succeeded in 2 min 56 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
erikjohnston
deleted the
erikj/rejoin_device_lists
branch
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
erikjohnston commentedSep 18, 2017
No description provided.