This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Do an AAAA lookup on SRV record targets #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/fix_ipv6_srv
branch
from
2e052d8
to
8d3615c
Compare
|
ok this seems better now. |
Support SRV records which point at AAAA records, as well as A records. Fixes #2405
richvdh
force-pushed
the
rav/fix_ipv6_srv
branch
from
8d3615c
to
c2407d7
Compare
| if answer.type == dns.A and answer.payload: | ||
| ip = answer.payload.dottedQuad() | ||
| host_ttl = min(srv_ttl, answer.ttl) | ||
| for (ip, ttl) in hosts: |
There was a problem hiding this comment.
technically doesn't need brackets
erikjohnston
approved these changes
Sep 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support SRV records which point at AAAA records, as well as A records.
Fixes #2405