Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Do an AAAA lookup on SRV record targets #2462
Conversation
richvdh
assigned
erikjohnston
and unassigned
erikjohnston
Sep 22, 2017
|
ok this seems better now. |
richvdh
assigned
erikjohnston
Sep 22, 2017
Some checks were not successful
| - if answer.type == dns.A and answer.payload: | ||
| - ip = answer.payload.dottedQuad() | ||
| - host_ttl = min(srv_ttl, answer.ttl) | ||
| + for (ip, ttl) in hosts: |
richvdh
merged commit f65e31d
into
develop
Sep 22, 2017
5 of 8 checks passed
Sytest Dendron (Commit)
Build #2610 origin/rav/fix_ipv6_srv failed in 16 sec
Details
Sytest SQLite (Commit)
Build #3538 origin/rav/fix_ipv6_srv failed in 2 min 1 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #3444 origin/rav/fix_ipv6_srv succeeded in 3 min 2 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
richvdh
referenced this pull request
Sep 22, 2017
Closed
Federation: SRV DNS record is ignored if it points to an IPv6 only (AAAA only) host #2405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
richvdh commentedSep 22, 2017
Support SRV records which point at AAAA records, as well as A records.
Fixes #2405