Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Make the spam checker a module #2474
+75
−23
Conversation
All checks have failed
Sytest Dendron (Commit)
— Build #2636 origin/dbkr/spam_check_module found unstable in 17 sec
Sytest Postgres (Commit)
— Build #3470 origin/dbkr/spam_check_module found unstable in 11 sec
dbkr
assigned
erikjohnston
Sep 26, 2017
| @@ -144,7 +143,7 @@ def callback(_, pdu, redacted): | ||
| ) | ||
| return redacted | ||
| - if spamcheck.check_event_for_spam(pdu): |
erikjohnston
Sep 27, 2017
Owner
So we're requiring this to be run synchronously? I.e., no IO while checking?
erikjohnston
Sep 27, 2017
Owner
I was more wondering whether we really want to preclude the spam checkers from e.g. accessing the DB, but ok.
dbkr
added some commits
Sep 27, 2017
Some checks were not successful
Sytest Postgres (Commit)
— Build #3472 origin/dbkr/spam_check_module succeeded in 3 min 43 sec
Sytest SQLite (Commit)
— Build #3566 origin/dbkr/spam_check_module succeeded in 2 min 36 sec
Some checks were not successful
Sytest Dendron (Commit)
— Build #2639 origin/dbkr/spam_check_module succeeded in 4 min 51 sec
Sytest Postgres (Commit)
— Build #3473 origin/dbkr/spam_check_module succeeded in 4 min 7 sec
Sytest SQLite (Commit)
— Build #3567 origin/dbkr/spam_check_module succeeded in 1 min 47 sec
Some checks were not successful
Sytest Postgres (Commit)
— Build #3474 origin/dbkr/spam_check_module succeeded in 4 min 10 sec
Sytest SQLite (Commit)
— Build #3568 origin/dbkr/spam_check_module succeeded in 1 min 58 sec
Some checks were not successful
Sytest Postgres (Commit)
— Build #3475 origin/dbkr/spam_check_module succeeded in 4 min 26 sec
Sytest SQLite (Commit)
— Build #3569 origin/dbkr/spam_check_module succeeded in 1 min 44 sec
dbkr
merged commit 74e494b
into
develop
Sep 27, 2017
7 of 8 checks passed
Sytest Dendron (Commit)
Build #2641 origin/dbkr/spam_check_module failed in 4 min 55 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #3475 origin/dbkr/spam_check_module succeeded in 4 min 26 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #3569 origin/dbkr/spam_check_module succeeded in 1 min 44 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
dbkr
deleted the
dbkr/spam_check_module
branch
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dbkr commentedSep 26, 2017
No description provided.