Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Allow spam checker to reject invites too #2492
Conversation
All checks have failed
Sytest Postgres (Commit)
— Build #3521 origin/dbkr/spam_check_invites failed in 3 min 11 sec
dbkr
assigned
erikjohnston
Oct 3, 2017
All checks have failed
Sytest Postgres (Commit)
— Build #3522 origin/dbkr/spam_check_invites failed in 3 min 16 sec
| + block_invite = True | ||
| + | ||
| + if not self.spam_checker.user_may_invite(requester.user): | ||
| + block_invite = True |
dbkr
added some commits
Oct 3, 2017
All checks have failed
Sytest Postgres (Commit)
— Build #3524 origin/dbkr/spam_check_invites failed in 2 min 55 sec
Some checks were not successful
Sytest Postgres (Commit)
— Build #3525 origin/dbkr/spam_check_invites succeeded in 4 min 13 sec
Sytest SQLite (Commit)
— Build #3619 origin/dbkr/spam_check_invites succeeded in 1 min 46 sec
Some checks were not successful
Sytest Postgres (Commit)
— Build #3526 origin/dbkr/spam_check_invites succeeded in 4 min 31 sec
Sytest SQLite (Commit)
— Build #3620 origin/dbkr/spam_check_invites succeeded in 1 min 46 sec
Some checks were not successful
Sytest Postgres (Commit)
— Build #3527 origin/dbkr/spam_check_invites succeeded in 4 min 30 sec
Sytest SQLite (Commit)
— Build #3621 origin/dbkr/spam_check_invites succeeded in 1 min 47 sec
Some checks were not successful
Sytest Postgres (Commit)
— Build #3528 origin/dbkr/spam_check_invites succeeded in 4 min 2 sec
Sytest SQLite (Commit)
— Build #3622 origin/dbkr/spam_check_invites succeeded in 3 min 0 sec
| @@ -45,3 +45,19 @@ def check_event_for_spam(self, event): | ||
| return False | ||
| return self.spam_checker.check_event_for_spam(event) | ||
| + | ||
| + def user_may_invite(self, userid): |
erikjohnston
Oct 3, 2017
Owner
I wonder if we also want to include the room_id here, so that you can fonx all invites for known bad rooms (or whitelist known good rooms)
Some checks were not successful
Sytest Postgres (Commit)
— Build #3529 origin/dbkr/spam_check_invites succeeded in 4 min 0 sec
Sytest SQLite (Commit)
— Build #3623 origin/dbkr/spam_check_invites succeeded in 2 min 50 sec
| @@ -45,3 +45,19 @@ def check_event_for_spam(self, event): | ||
| return False | ||
| return self.spam_checker.check_event_for_spam(event) | ||
| + | ||
| + def user_may_invite(self, userid, roomid): |
Some checks were not successful
Sytest Postgres (Commit)
— Build #3530 origin/dbkr/spam_check_invites succeeded in 3 min 50 sec
Sytest SQLite (Commit)
— Build #3624 origin/dbkr/spam_check_invites succeeded in 1 min 46 sec
dbkr
merged commit 5f20a91
into
develop
Oct 3, 2017
6 of 8 checks passed
Sytest Dendron (Commit)
Build #2696 origin/dbkr/spam_check_invites failed in 1 min 32 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #3530 origin/dbkr/spam_check_invites succeeded in 3 min 50 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #3624 origin/dbkr/spam_check_invites succeeded in 1 min 46 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
dbkr
deleted the
dbkr/spam_check_invites
branch
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dbkr commentedOct 3, 2017
No description provided.