Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Add room creation checks to spam checker #2495
Conversation
Some checks were not successful
Sytest Dendron (Commit)
— Build #2698 origin/dbkr/spam_check_room_creation failed in 4 min 56 sec
Sytest Postgres (Commit)
— Build #3532 origin/dbkr/spam_check_room_creation succeeded in 4 min 7 sec
Sytest SQLite (Commit)
— Build #3626 origin/dbkr/spam_check_room_creation succeeded in 2 min 55 sec
dbkr
assigned
erikjohnston
Oct 4, 2017
| @@ -75,6 +80,9 @@ def create_room(self, requester, config, ratelimit=True): | ||
| """ | ||
| user_id = requester.user.to_string() | ||
| + if not self.spam_checker.user_may_create_room(user_id): | ||
| + raise SynapseError(403, "You are not permitted to create rooms") |
dbkr
added some commits
Oct 4, 2017
Some checks were not successful
Sytest Dendron (Commit)
— Build #2699 origin/dbkr/spam_check_room_creation failed in 3 min 50 sec
Sytest Postgres (Commit)
— Build #3533 origin/dbkr/spam_check_room_creation succeeded in 3 min 51 sec
Sytest SQLite (Commit)
— Build #3627 origin/dbkr/spam_check_room_creation succeeded in 2 min 50 sec
Some checks were not successful
Sytest Dendron (Commit)
— Build #2700 origin/dbkr/spam_check_room_creation failed in 4 min 30 sec
Sytest Postgres (Commit)
— Build #3534 origin/dbkr/spam_check_room_creation succeeded in 4 min 20 sec
Sytest SQLite (Commit)
— Build #3628 origin/dbkr/spam_check_room_creation succeeded in 1 min 52 sec
dbkr
merged commit 93b0cf7
into
develop
Oct 4, 2017
6 of 8 checks passed
Sytest Dendron (Commit)
Build #2700 origin/dbkr/spam_check_room_creation failed in 4 min 30 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #3534 origin/dbkr/spam_check_room_creation succeeded in 4 min 20 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #3628 origin/dbkr/spam_check_room_creation succeeded in 1 min 52 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
dbkr
deleted the
dbkr/spam_check_room_creation
branch
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dbkr commentedOct 4, 2017
Lets the spam checker deny attempts to create rooms and add aliases
to them.