Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Fix notif kws that start/end with non-word chars #2500
Conversation
dbkr
added some commits
Oct 5, 2017
Some checks were not successful
Sytest Dendron (Commit)
— Build #2702 origin/dbkr/fix_word_boundary_mentions failed in 4 min 4 sec
Sytest Postgres (Commit)
— Build #3536 origin/dbkr/fix_word_boundary_mentions succeeded in 3 min 22 sec
Sytest SQLite (Commit)
— Build #3630 origin/dbkr/fix_word_boundary_mentions succeeded in 3 min 7 sec
Some checks were not successful
Sytest Dendron (Commit)
— Build #2703 origin/dbkr/fix_word_boundary_mentions succeeded in 5 min 4 sec
Sytest Postgres (Commit)
— Build #3537 origin/dbkr/fix_word_boundary_mentions succeeded in 4 min 29 sec
Sytest SQLite (Commit)
— Build #3631 origin/dbkr/fix_word_boundary_mentions succeeded in 1 min 45 sec
ara4n
self-assigned this
Oct 5, 2017
Some checks were not successful
Sytest Dendron (Commit)
— Build #2706 origin/dbkr/fix_word_boundary_mentions failed in 3 min 21 sec
Sytest Postgres (Commit)
— Build #3539 origin/dbkr/fix_word_boundary_mentions succeeded in 3 min 31 sec
Sytest SQLite (Commit)
— Build #3634 origin/dbkr/fix_word_boundary_mentions succeeded in 1 min 47 sec
|
lgtm! |
ara4n
assigned
dbkr
and unassigned
ara4n
Oct 5, 2017
dbkr
merged commit 44f8e38
into
develop
Oct 5, 2017
6 of 8 checks passed
Sytest Dendron (Commit)
Build #2706 origin/dbkr/fix_word_boundary_mentions failed in 3 min 21 sec
Details
Sytest Dendron (Merged PR)
Build finished.
Details
Sytest Postgres (Commit)
Build #3539 origin/dbkr/fix_word_boundary_mentions succeeded in 3 min 31 sec
Details
Sytest Postgres (Merged PR)
Build finished.
Details
Sytest SQLite (Commit)
Build #3634 origin/dbkr/fix_word_boundary_mentions succeeded in 1 min 47 sec
Details
Sytest SQLite (Merged PR)
Build finished.
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
This was referenced Oct 5, 2017
dbkr
deleted the
dbkr/fix_word_boundary_mentions
branch
Oct 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dbkr commentedOct 5, 2017
•
edited by ara4n
Only prepend / append word boundary characters if the search
expression starts or ends with a word character, otherwise they
don't work because there's no word boundary between whitespace and
a non-word char.