Support for channel notifications

[dbkr]

Add condition type to check the sender's power level and add a base
rule using it for @channel notifications.

Thought: should we add a layer of indirection here so a channel can configure the minimum PL for sending a channel bing?

[ara4n]

let's call it @room

[erikjohnston]

you want .itervalues() here (which returns an iterator rather than constructing a new list)

[erikjohnston]

I'd probably also move this in to the else, and explicitly do:

pl_event_key = (EventTypes.PowerLevels, "", )
pl_event_id = context.prev_state_ids.get((EventTypes.PowerLevels, "",))
if pl_event_id:
    pl_event = yield self.store.get_event(pl_event_id)
    auth_events = { pl_event_key: pl_event }
else:
    ...
defer.returnValue(get_user_power_level(event.sender, auth_events))

to avoid some allocations

[dbkr]

is it worth s/values/itervalues/ in the place I copied it from and all the other places that copied it from that too? :)

[erikjohnston]

Almost certainly, so long as its obvious how its used

[ara4n]

i'd avoid overcomplicating it with the layer of indirection to set a powerlevel for channel bing. if folks want that they can just surely add a custom push rule in the client (or in their particular server). conceptually this looks fine to me, but needs input from @erikjohnston on the state wrangling.

[erikjohnston]

It's faster to do:

pl_event = context.prev_state_ids.get((EventTypes.PowerLevels, "",))
if pl_event:
   ...

[turt2live]

2015?