New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to run tests in PostgreSQL in Docker #3699

Merged
merged 9 commits into from Sep 20, 2018

Conversation

2 participants
@hawkowl
Contributor

hawkowl commented Aug 15, 2018

No description provided.

hawkowl added some commits Aug 15, 2018

@hawkowl hawkowl requested a review from matrix-org/synapse-core Aug 15, 2018

@richvdh

a couple of suggestions to help with maintaining this stuff...

build, this will be shown in GitHub, so please keep an eye on the pull request
for feedback.
To run unit tests, you can use:

This comment has been minimized.

@richvdh

richvdh Aug 20, 2018

Member

suggest "To run unit tests on a development environment ..." to distinguish from the previous paragraph about CI and PRs

@@ -0,0 +1,8 @@
FROM matrixdotorg/sytest:latest

This comment has been minimized.

@richvdh

richvdh Aug 20, 2018

Member

can we stick the Dockerfile in the docker directory to avoid cluttering the top-level more than necessary?

MANIFEST.in Outdated
@@ -28,6 +28,9 @@ exclude jenkins*.sh
exclude jenkins*
exclude Dockerfile
exclude .dockerignore
exclude Dockerfile-pgtests

This comment has been minimized.

@richvdh

richvdh Aug 20, 2018

Member

this is probably redundant if the dockerfile is in the docker dir?

@@ -0,0 +1,3 @@
#! /usr/bin/env bash

This comment has been minimized.

@richvdh

richvdh Aug 20, 2018

Member

#!/bin/bash is conventional for shell scripts.

Does it need a set -e so that it doesn't plough on with the run if the build fails?

@@ -0,0 +1,10 @@
export PGDATA=/var/lib/postgresql/data

This comment has been minimized.

@richvdh

richvdh Aug 20, 2018

Member

could do with a shebang line and a comment saying what it does?

and a set -e maybe?

This comment has been minimized.

@richvdh

richvdh Aug 20, 2018

Member

can it go in a subdir?

This comment has been minimized.

@hawkowl

hawkowl Sep 19, 2018

Contributor

done

@@ -0,0 +1,8 @@
FROM matrixdotorg/sytest:latest

This comment has been minimized.

@richvdh

richvdh Aug 20, 2018

Member

can it also have a comment saying what it does?

@richvdh

This comment has been minimized.

Member

richvdh commented Sep 18, 2018

@hawkowl bump

@hawkowl hawkowl added this to In Progress in Backend Core Team Sep 19, 2018

@hawkowl hawkowl requested a review from matrix-org/synapse-core Sep 19, 2018

@richvdh

lgtm

the Jenkins builds require an adminstrator to start them. If your change
breaks the build, this will be shown in github, so please keep an eye on the
pull request for feedback.
We use `Jenkins <http://matrix.org/jenkins>`_, `CircleCI

This comment has been minimized.

@richvdh

richvdh Sep 19, 2018

Member

(we don't use jenkins any more...)

hawkowl added some commits Sep 20, 2018

@hawkowl hawkowl merged commit 741571c into develop Sep 20, 2018

10 checks passed

ci/circleci: sytestpy2 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

Backend Core Team automation moved this from In Progress to Done Sep 20, 2018

@hawkowl hawkowl deleted the hawkowl/pg-tests-docker branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment