Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Speed up lazy loading #3827
I've only had a chance to look at the lazy loading bits of this. Can you please split out the fixes to get_filtered_current_state_ids to a separate PR please?
Things look broadly fine, other than its quite confusing trying to keep track of what
r is any given situation. Hopefully the suggested changes will help clear things up a bit.
The only major thing is whether we are currently pulling the members out of the database. It feels odd to pull out 6 arbitrary users regardless of membership, while it seems the sync code assumes that e.g. if there are joined users in the room
MemberSummary.members will be nonempty
done, it's back in #3792
Right. i guess it needs an