New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to enable recording IPs for appservice users #3831

Merged
merged 4 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@turt2live
Member

turt2live commented Sep 9, 2018

Primarily useful for MAU and not much else, such as when combined with #3830

turt2live added some commits Sep 9, 2018

@turt2live turt2live referenced this pull request Sep 12, 2018

Closed

MAU transaction errors #3854

@richvdh richvdh requested a review from matrix-org/synapse-core Sep 18, 2018

access_token=access_token,
ip=ip_addr,
user_agent=user_agent,
device_id="", # stubbed

This comment has been minimized.

@erikjohnston

erikjohnston Sep 20, 2018

Member

Can this be "dummy-device" or None, as empty string can cause all sorts of silly issues, e.g. when looking at the db

@turt2live turt2live self-assigned this Sep 27, 2018

@turt2live

This comment has been minimized.

Member

turt2live commented Oct 16, 2018

This was done with an unpaid hat on:

Signed-off-by: Travis Ralston travpc@gmail.com

@turt2live turt2live removed their assignment Oct 16, 2018

@richvdh

This comment has been minimized.

Member

richvdh commented Dec 4, 2018

I'm assuming we're happy with this now.

@richvdh richvdh merged commit 1737753 into matrix-org:develop Dec 4, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@turt2live turt2live deleted the turt2live:travis/appservice-ips branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment