New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some b'abcd' noise in logs and metrics #3892

Merged
merged 2 commits into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@richvdh
Member

richvdh commented Sep 17, 2018

Python 3 compatibility: make sure that we decode some byte sequences before we
use them to create log lines and metrics labels.

richvdh added some commits Sep 17, 2018

Fix some b'abcd' noise in logs and metrics
Python 3 compatibility: make sure that we decode some byte sequences before we
use them to create log lines and metrics labels.

@richvdh richvdh requested a review from matrix-org/synapse-core Sep 17, 2018

@richvdh richvdh merged commit c7131ba into develop Sep 17, 2018

14 checks passed

Synapse Sytest Postgres (Commit) Build #7057 origin/rav/decode_bytes_in_request_logs succeeded in 6 min 42 sec
Details
Synapse Sytest Postgres (Merged PR) Build finished.
Details
Synapse Sytest SQLite (Commit) Build #7270 origin/rav/decode_bytes_in_request_logs succeeded in 3 min 35 sec
Details
Synapse Sytest SQLite (Merged PR) Build finished.
Details
ci/circleci: sytestpy2 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh added the py3 label Sep 17, 2018

@hawkowl hawkowl deleted the rav/decode_bytes_in_request_logs branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment