New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matrixfederationclient.py logging: Destination is a string #3909

Merged
merged 2 commits into from Sep 19, 2018

Conversation

Projects
None yet
3 participants
@turt2live
Member

turt2live commented Sep 18, 2018

Fixes:

homeserver_1 - 2018-09-18 21:23:03,084 - twisted - 243 - ERROR - PUT-466 - Traceback (most recent call last):
homeserver_1 - 2018-09-18 21:23:03,084 - twisted - 243 - ERROR - PUT-466 -   File "/usr/lib/python2.7/logging/handlers.py", line 76, in emit
homeserver_1 - 2018-09-18 21:23:03,085 - twisted - 243 - ERROR - PUT-466 -     if self.shouldRollover(record):
homeserver_1 - 2018-09-18 21:23:03,086 - twisted - 243 - ERROR - PUT-466 -   File "/usr/lib/python2.7/logging/handlers.py", line 156, in shouldRollover
homeserver_1 - 2018-09-18 21:23:03,087 - twisted - 243 - ERROR - PUT-466 -     msg = "%s\n" % self.format(record)
homeserver_1 - 2018-09-18 21:23:03,088 - twisted - 243 - ERROR - PUT-466 -   File "/usr/lib/python2.7/logging/__init__.py", line 734, in format
homeserver_1 - 2018-09-18 21:23:03,088 - twisted - 243 - ERROR - PUT-466 -     return fmt.format(record)
homeserver_1 - 2018-09-18 21:23:03,089 - twisted - 243 - ERROR - PUT-466 -   File "/usr/lib/python2.7/logging/__init__.py", line 465, in format
homeserver_1 - 2018-09-18 21:23:03,090 - twisted - 243 - ERROR - PUT-466 -     record.message = record.getMessage()
homeserver_1 - 2018-09-18 21:23:03,090 - twisted - 243 - ERROR - PUT-466 -   File "/usr/lib/python2.7/logging/__init__.py", line 329, in getMessage
homeserver_1 - 2018-09-18 21:23:03,091 - twisted - 243 - ERROR - PUT-466 -     msg = msg % self.args
homeserver_1 - 2018-09-18 21:23:03,092 - twisted - 243 - ERROR - PUT-466 - TypeError: %d format: a number is required, not unicode
homeserver_1 - 2018-09-18 21:23:03,092 - twisted - 243 - ERROR - PUT-466 - Logged from file matrixfederationclient.py, line 164
homeserver_1 - 2018-09-18 21:23:03,093 - twisted - 243 - ERROR - PUT-466 - Traceback (most recent call last):
homeserver_1 - 2018-09-18 21:23:03,094 - twisted - 243 - ERROR - PUT-466 -   File "/usr/lib/python2.7/logging/__init__.py", line 861, in emit
homeserver_1 - 2018-09-18 21:23:03,095 - twisted - 243 - ERROR - PUT-466 -     msg = self.format(record)
homeserver_1 - 2018-09-18 21:23:03,095 - twisted - 243 - ERROR - PUT-466 -   File "/usr/lib/python2.7/logging/__init__.py", line 734, in format
homeserver_1 - 2018-09-18 21:23:03,096 - twisted - 243 - ERROR - PUT-466 -     return fmt.format(record)
homeserver_1 - 2018-09-18 21:23:03,096 - twisted - 243 - ERROR - PUT-466 -   File "/usr/lib/python2.7/logging/__init__.py", line 465, in format
homeserver_1 - 2018-09-18 21:23:03,097 - twisted - 243 - ERROR - PUT-466 -     record.message = record.getMessage()
homeserver_1 - 2018-09-18 21:23:03,098 - twisted - 243 - ERROR - PUT-466 -   File "/usr/lib/python2.7/logging/__init__.py", line 329, in getMessage
homeserver_1 - 2018-09-18 21:23:03,098 - twisted - 243 - ERROR - PUT-466 -     msg = msg % self.args
homeserver_1 - 2018-09-18 21:23:03,099 - twisted - 243 - ERROR - PUT-466 - TypeError: %d format: a number is required, not unicode
homeserver_1 - 2018-09-18 21:23:03,099 - twisted - 243 - ERROR - PUT-466 - Logged from file matrixfederationclient.py, line 164

Introduced by #3906

turt2live added some commits Sep 18, 2018

@turt2live turt2live requested a review from matrix-org/synapse-core Sep 18, 2018

@hawkowl hawkowl merged commit 47c02e6 into matrix-org:develop Sep 19, 2018

9 checks passed

ci/circleci: sytestpy2 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@richvdh

This comment has been minimized.

Member

richvdh commented Sep 19, 2018

🤦‍♂️

@@ -0,0 +1 @@
Fix log format error in matrixfederationclient.py

This comment has been minimized.

@richvdh

richvdh Sep 19, 2018

Member

would be nice if this had the same text as #3906 so that the changelog entries get combined. I'll just change that on develop.

richvdh added a commit that referenced this pull request Sep 19, 2018

@turt2live turt2live deleted the turt2live:travis/fix-logging-1 branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment