New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a regression test for logging on failed connections #3912

Merged
merged 6 commits into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@hawkowl
Contributor

hawkowl commented Sep 19, 2018

Fixes #3799

@hawkowl hawkowl requested a review from matrix-org/synapse-core Sep 19, 2018

@erikjohnston

Other than changelog, lgtm

@@ -0,0 +1 @@
Add a regression test for logging failed HTTP requests on Python 3.

This comment has been minimized.

@erikjohnston

erikjohnston Sep 19, 2018

Member

Isn't the important thing in this PR that we fix the logging, rather than adding a test?

This comment has been minimized.

@hawkowl

hawkowl Sep 20, 2018

Contributor

I fixed the logging in another PR (that caused the exception). The logging fix here is just a sneaky b'' showing up fix :)

@hawkowl hawkowl merged commit aeca5a5 into develop Sep 20, 2018

10 checks passed

ci/circleci: sytestpy2 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hawkowl hawkowl deleted the hawkowl/py3-failedreq branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment