New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_destination_retry_timings cache #3914

Merged
merged 4 commits into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@erikjohnston
Member

erikjohnston commented Sep 19, 2018

Currently we rely on the master to invalidate this cache promptly.
However, after having moved most federation endpoints off of master this
no longer happens, causing outbound fedeariont to get blackholed.

Fixes #3798

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Sep 19, 2018

erikjohnston added some commits Sep 19, 2018

Remove get_destination_retry_timings cache
Currently we rely on the master to invalidate this cache promptly.
However, after having moved most federation endpoints off of master this
no longer happens, causing outbound fedeariont to get blackholed.

Fixes #3798
@richvdh

could probably do with deleting the XXX at line 199.

otherwise LGTM

@@ -0,0 +1 @@
Fix bug where outboud federation would stop talking to some servers when using workers

This comment has been minimized.

@richvdh

richvdh Sep 19, 2018

Member

outboud

@richvdh

This comment has been minimized.

Member

richvdh commented Sep 19, 2018

fedeariont

NOES, not the fearsome FEDEARIONT!

@erikjohnston

This comment has been minimized.

Member

erikjohnston commented Sep 19, 2018

I wonder if there exists a tool to monitor all outbound network traffic from my computer and run it through a spell checker...

@erikjohnston erikjohnston merged commit 3fd68d5 into develop Sep 20, 2018

10 checks passed

ci/circleci: sytestpy2 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@erikjohnston erikjohnston deleted the erikj/remove_retry_cache branch Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment