Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
only try to LL members after a non-gappy incr sync if the timeline has events #3936
well, the code looks fine I guess, so if we're really in a hurry we could merge it. However:
- I don't really understand why #3916 was a thing: why would we want to include our member event for each and every incremental sync? (vector-im/riot-web#7282 talks about doing this for initial sync, but doesn't explain why it was necessary for incremental sync).
- given we seem to have sytests which test #3916, could they not be tweaked to catch this edge-case?
We LL ourselves in case it's a gappy sync, and in case we were doing LL over gappy syncs (i.e. if #3840 hadn't disabled it). In practice the members will get removed by the anti-redundancy code. In practice I guess we can move it to only apply to initial syncs for now to avoid needless work; will do so.
Yup, the sytests could catch this edge case.