New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix userconsent on Python 3 #3938

Merged
merged 14 commits into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@hawkowl
Contributor

hawkowl commented Sep 24, 2018

No description provided.

@hawkowl hawkowl requested a review from matrix-org/synapse-core Sep 28, 2018

@richvdh

richvdh approved these changes Oct 1, 2018

lgtm otherwise

def default_config(self, name="test"):
"""
Get a default HomeServer config object.
"""

This comment has been minimized.

@richvdh

richvdh Oct 1, 2018

Member

could you document what name is naming?

@hawkowl hawkowl merged commit 6e05fd0 into develop Oct 1, 2018

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hawkowl hawkowl deleted the hawkowl/py3-userconsent branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment