New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue with older Twisted in tests #3940

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@OlegGirko

OlegGirko commented Sep 24, 2018

Older Twisted (18.4.0) returns TimeoutError instead of ConnectingCancelledError when connection times out.
This change allows tests to be compatible with this behaviour.

Oleg Girko
Fix compatibility issue with older Twisted in tests.
Older Twisted (18.4.0) returns TimeoutError instead of
ConnectingCancelledError when connection times out.
This change allows tests to be compatible with this behaviour.

Signed-off-by: Oleg Girko <ol@infoserver.lv>

hawkowl added a commit that referenced this pull request Sep 24, 2018

Merge tag 'v0.33.5.1'
Internal Changes
----------------

- Fix incompatibility with older Twisted version in tests. Thanks
  @OlegGirko!
([\#3940](#3940))
@hawkowl

This comment has been minimized.

Contributor

hawkowl commented Sep 24, 2018

Thanks @OlegGirko . I cherry picked this onto 0.33.5.1, and it's now released & merged through that.

@hawkowl hawkowl closed this Sep 24, 2018

@OlegGirko OlegGirko deleted the OlegGirko:fix_twisted_compat_in_tests branch Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment