New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExpiringCache.__len__ to be accurate #3956

Merged
merged 3 commits into from Sep 26, 2018

Conversation

Projects
None yet
2 participants
@richvdh
Member

richvdh commented Sep 26, 2018

It used to try and produce an estimate, which was sometimes negative. This caused metrics to be sad, so lets always just calculate it from scratch.

(This appears to have been a longstanding bug, but one which has been made more of a problem by #3932 and #3933).

(This was originally done by Erik as part of #3933. I'm cherry-picking it because really it's a fix in its own right)

erikjohnston and others added some commits Sep 21, 2018

Fix ExpiringCache.__len__ to be accurate
It used to try and produce an estimate, which was sometimes negative.
This caused metrics to be sad, so lets always just calculate it from
scratch.

(This appears to have been a longstanding bug, but one which has been made more
of a problem by #3932 and #3933).

(This was originally done by Erik as part of #3933. I'm cherry-picking it
because really it's a fix in its own right)

@richvdh richvdh merged commit 4e8276a into develop Sep 26, 2018

5 of 10 checks passed

ci/circleci: sytestpy3postgres Your CircleCI tests were canceled
Details
ci/circleci: sytestpy2 Your tests are queued behind your running builds
Details
ci/circleci: sytestpy2postgresmerged Your tests are queued behind your running builds
Details
ci/circleci: sytestpy3 Your tests are queued behind your running builds
Details
ci/circleci: sytestpy3postgresmerged Your tests are queued behind your running builds
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hawkowl hawkowl deleted the rav/fix_expiring_cache_len branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment