New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docstrings and unittests for storage.state #3958

Merged
merged 5 commits into from Sep 27, 2018

Conversation

Projects
None yet
2 participants
@richvdh
Member

richvdh commented Sep 26, 2018

I spent ages trying to figure out how I was going mad... Turns out the docstrings on some of these were complete lies, in claiming that they returned EventBase objects rather than event ids.

richvdh added some commits Sep 21, 2018

docstrings and unittests for storage.state
I spent ages trying to figure out how I was going mad...

@richvdh richvdh requested a review from matrix-org/synapse-core Sep 26, 2018

richvdh added some commits Sep 26, 2018

@richvdh richvdh merged commit ae6ad4c into develop Sep 27, 2018

10 checks passed

ci/circleci: sytestpy2 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3 Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgres Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/state_store_tests branch Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment