New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run notify_app_services as a bg process #3965

Merged
merged 2 commits into from Sep 27, 2018

Conversation

Projects
None yet
2 participants
@richvdh
Member

richvdh commented Sep 26, 2018

This ensures that its resource usage metrics get recorded somewhere rather
than getting lost.

(It also fixes an error when called from a nested logging context which
completes before the bg process)

richvdh added some commits Sep 26, 2018

Run notify_app_services as a bg process
This ensures that its resource usage metrics get recorded somewhere rather than
getting lost.

(It also fixes an error when called from a nested logging context which
completes before the bg process)

@richvdh richvdh requested a review from matrix-org/synapse-core Sep 27, 2018

@hawkowl hawkowl merged commit 6de3884 into develop Sep 27, 2018

6 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hawkowl hawkowl deleted the rav/notify_app_services_bg_process branch Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment