New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions to point to pip install #3985

Merged
merged 7 commits into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@hawkowl
Contributor

hawkowl commented Oct 1, 2018

No description provided.

@hawkowl hawkowl requested a review from matrix-org/synapse-core Oct 1, 2018

@hawkowl

This comment has been minimized.

Contributor

hawkowl commented Oct 1, 2018

Fixes #1224

@richvdh

The tarball is referenced at other places too (eg, under Arch Linux and OpenBSD)

There is also an UPGRADE.rst which needs updating.

(while you're in the README: any chance you can delete the stuff at https://github.com/matrix-org/synapse/blob/master/README.rst#ipv6 about needing a new twisted, since we now require that by default)

@@ -9,13 +9,16 @@ source $BASH_ENV
if [[ -z "${CIRCLE_PR_NUMBER}" ]]
then
echo "Can't figure out what the PR number is!"
exit 1
echo "Can't figure out what the PR number is! Assuming develop."

This comment has been minimized.

@richvdh

richvdh Oct 1, 2018

Member

this looks unrelated, though useful.

I would s/Assuming develop/Assuming it will be based on develop/ though.

fixed

@hawkowl hawkowl requested a review from matrix-org/synapse-core Oct 1, 2018

@@ -533,9 +512,7 @@ fix try re-installing from PyPI or directly from
# Install from PyPI
pip install --user --upgrade --force pynacl
# Install from github
pip install --user https://github.com/pyca/pynacl/tarball/master

This comment has been minimized.

@richvdh

richvdh Oct 1, 2018

Member

synapse != pynacl

This comment has been minimized.

@hawkowl

hawkowl Oct 1, 2018

Contributor

oh

fixes

@hawkowl hawkowl requested a review from matrix-org/synapse-core Oct 1, 2018

@@ -459,7 +459,7 @@ Troubleshooting
Troubleshooting Installation
----------------------------
Synapse requires pip 1.7 or later, so if your OS provides too old a version you
Synapse requires pip 8 or later, so if your OS provides too old a version you

This comment has been minimized.

@richvdh

richvdh Oct 1, 2018

Member

1.7lol

This comment has been minimized.

@hawkowl

hawkowl Oct 1, 2018

Contributor

1.7, ahh, such a classic pip release (which literally won't install packages now)

@richvdh

lgtm

@hawkowl hawkowl merged commit abdc141 into develop Oct 1, 2018

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hawkowl hawkowl deleted the hawkowl/pip-install branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment