New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jenkins & other old dev junk #3988

Merged
merged 7 commits into from Oct 2, 2018

Conversation

Projects
None yet
4 participants
@hawkowl
Contributor

hawkowl commented Oct 1, 2018

No description provided.

@ara4n

This comment has been minimized.

Member

ara4n commented Oct 1, 2018

deleting the copyright-maintaining scripts feels a bit savage; the bug is that we don't use them, not that they exist...

@ara4n

This comment has been minimized.

Member

ara4n commented Oct 1, 2018

likewise, the directory map, whilst stale, is surely still useful for noobs? (but could be moved into /docs)

@hawkowl hawkowl requested a review from matrix-org/synapse-core Oct 2, 2018

@erikjohnston

Lets not block removing jenkins config with a discussion about what dev scripts we can remove, so can we split the PRs? (Or just delete the jenkins stuff)

@richvdh

richvdh approved these changes Oct 2, 2018

lgtm.

The map is stale enough that it is far more likely to be a hinderance than a help to anyone. There is no point having it unless it is maintained, and I don't believe that maintaining it is worthwhile.

I don't have strong feelings about the copyright scripts (they aren't cluttering up /, which helps). I'm not convinced that it is ever correct to go and replace the copyright notice wholesale on files which haven't been touched for some time (or those that have, by other contributors with other copyright notices). And anyway I don't really know how to use them. Personally I'd get rid of them but whatever.

@richvdh

This comment has been minimized.

Member

richvdh commented Oct 2, 2018

@erikjohnston the map is the thing that I most want to kill off here.

@hawkowl

This comment has been minimized.

Contributor

hawkowl commented Oct 2, 2018

FWIW, the directory map is currently worse than nothing. If we want an explainer of what modules and folders are, we can put README.md's in them.

As far as the copyright scripter, it isn't of much use (plus, the copyright header per file is not really... useful, but that's another thing).

@richvdh

This comment has been minimized.

Member

richvdh commented Oct 2, 2018

hawkowl added some commits Oct 2, 2018

@hawkowl hawkowl merged commit 058a4c6 into develop Oct 2, 2018

6 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hawkowl hawkowl deleted the hawkowl/remove-jenkins branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment