New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when invalidating destination retry timings #3991

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@erikjohnston
Member

erikjohnston commented Oct 2, 2018

No description provided.

@erikjohnston erikjohnston requested a review from matrix-org/synapse-core Oct 2, 2018

@richvdh

can you link to the original PR from here please

@@ -0,0 +1 @@
Fix bug when invalidating destination retry timings

This comment has been minimized.

@richvdh

richvdh Oct 2, 2018

Member

can you update this to match the description of the original PR so that the changelog entries get combined, please.

This comment has been minimized.

@erikjohnston

erikjohnston Oct 2, 2018

Member

Oooh, good point

@erikjohnston

This comment has been minimized.

Member

erikjohnston commented Oct 2, 2018

This was broken in #3933

@richvdh

richvdh approved these changes Oct 2, 2018

lgtm

@richvdh

richvdh approved these changes Oct 2, 2018

still lgtm

@erikjohnston erikjohnston merged commit 25baf3b into develop Oct 2, 2018

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment