Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
E2E backups #4019
Note that most of this has already been reviewed when it was in 2731 (unsure if it would be easier or more confusing to merge this branch over to that one and re-open that PR).
Looks good! Just needs a little bit of sprucing up.
FTR: I've only really been reviewing the code, rather than trying to grok how E2E backups are meant to work as a whole.
For future reference, it'd also be good to avoid using
@defer.inlineCallbacks in tests and instead use the test reactor infrastructure (which is also fairly nice). There are a number of advantages to this (Though personally the main one is that if you CTRL^C trial it sometimes completely wedges if using a real reactor)