New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups in the federation client code #4031

Merged
merged 2 commits into from Oct 16, 2018

Conversation

3 participants
@richvdh
Member

richvdh commented Oct 12, 2018

  • Improve logging: log things in the right order, include destination and txids
    in all log lines, don't log successful responses twice

  • Fix the docstring on TransportLayerClient.send_transaction

  • Don't use treq.request, which is overcomplicated for our purposes: just use a
    twisted.web.client.Agent.

  • simplify the logic for setting up the bodyProducer

@richvdh richvdh requested a review from matrix-org/synapse-core Oct 12, 2018

Various cleanups in the federation client code
- Improve logging: log things in the right order, include destination and txids
  in all log lines, don't log successful responses twice

- Fix the docstring on TransportLayerClient.send_transaction

- Don't use treq.request, which is overcomplicated for our purposes: just use a
  twisted.web.client.Agent.

- simplify the logic for setting up the bodyProducer
@hawkowl

This comment has been minimized.

Contributor

hawkowl commented Oct 12, 2018

🤔 all the builds failed

@erikjohnston

This comment has been minimized.

Member

erikjohnston commented Oct 12, 2018

I take it all back

@erikjohnston

The tests are angry

the tests are no longer angry

@richvdh richvdh requested a review from matrix-org/synapse-core Oct 16, 2018

@richvdh richvdh merged commit b8a5b00 into develop Oct 16, 2018

6 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/cleanup_federation_client branch Oct 16, 2018

@richvdh richvdh added this to To Do in Backend Core Team via automation Oct 17, 2018

@richvdh richvdh moved this from To Do to Done - Operations in Backend Core Team Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment