Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roomlist since tokens on Python 3 #4046

Merged
merged 11 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@Half-Shot
Copy link
Contributor

Half-Shot commented Oct 16, 2018

Fixes #4039

@hawkowl

This comment has been minimized.

Copy link
Contributor

hawkowl commented Oct 17, 2018

I think this is the opposite of what we should be doing here -- we should be decoding the on-wire into Unicode. We shouldn't have bytestrings in our internal objects.

@richvdh
Copy link
Member

richvdh left a comment

what she said

Half-Shot and others added some commits Oct 17, 2018

@hawkowl hawkowl merged commit d6a7797 into matrix-org:develop Oct 17, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.