Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add config option to control alias creation #4051
the lack of UTs on this makes me unhappy - I think this sort of stuff is easy to screw up (cf the anchoring bug, for example), but very amenable to testing.
What do we expect to happen when somebody calls
/createRoom with a
room_alias_name, and the alias fails? I suspect the whole thing is going to fail with a 403, despite the room getting successfully created, which is less than ideal.
Ugh yes, I was going to ask how to add UTs as we don't currently test any of the config stuff. I could just manually insert the list of parsed
True, I haven't looked as was just expanding the rules already there. Will investigate, though I'm not sure what the right thing to do is (in terms of failing the request vs succeeding without the alias)
moved this from To Do
to In Progress: Operational/bug fixes
in Backend Core Team
Oct 18, 2018
Actually, we register the alias before creating the room, so it'll fail without creating the room if the alias is taken.