Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Clean up the way logcontexts and threads work in the pushers #4075
This was all a bit of an inconsistent confusing mess, and led to things being
The starting point is to note that each pusher has its own loop which runs for
Once we've done that, it turns out that the hooks to notify the pushers
Sorry about the size of this PR - it's broken down into commits doing roughly the above, preceeded by a bunch of refactoring to make it tractable.
This looks like a big improvement. I'm not hugely thrilled about the disconnect between checks to
is_processing and actually setting
is_processing, it looks like it could be quite a large footgun if we're not careful. Could we add a check within the processing loops too? So that yes we normally bail out early, but for paranoia's sake we double check before actually setting it and doing the work?