Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a number of flake8 errors #4082

Merged
merged 1 commit into from Oct 24, 2018

Conversation

2 participants
@richvdh
Copy link
Member

richvdh commented Oct 24, 2018

Broadly three things here:

  • disable W504 which seems a bit whacko
  • remove a bunch of as e expressions from exception handlers that don't use them
  • use r"" for strings which include backslashes

Also, we don't use pep8 any more, so we can get rid of the duplicate config
there.

(This will still fail pep8 in synapse/api/filtering.py due to an actual bug which I am actually going to fix in an actual different PR)

Fix a number of flake8 errors
Broadly three things here:

* disable W504 which seems a bit whacko
* remove a bunch of `as e` expressions from exception handlers that don't use
  them
* use `r""` for strings which include backslashes

Also, we don't use pep8 any more, so we can get rid of the duplicate config
there.

@richvdh richvdh requested a review from matrix-org/synapse-core Oct 24, 2018

@richvdh richvdh merged commit 7328039 into develop Oct 24, 2018

4 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details

@richvdh richvdh deleted the rav/fix_pep8 branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.