Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow backslashes in event field filters #4083

Merged
merged 2 commits into from Oct 24, 2018

Conversation

2 participants
@richvdh
Copy link
Member

richvdh commented Oct 24, 2018

Fixes a bug introduced in #1783 which meant that single backslashes were not allowed in event field filters.

The intention here is to allow single-backslashes, but disallow double-backslashes.

("^((?!\\\).)*$" comes out as ^((?!\\).)*$, which is a regex matching things which don't include a single \.)

Allow backslashes in event field filters
Fixes a bug introduced in #1783 which
meant that single backslashes were not allowed in event field filters.

The intention here is to allow single-backslashes, but disallow
double-backslashes.

@richvdh richvdh requested a review from matrix-org/synapse-core Oct 24, 2018

@richvdh richvdh merged commit 78e8d4c into develop Oct 24, 2018

6 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@richvdh richvdh deleted the rav/fix_event_filter_validation branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.