Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port register_new_matrix_user to Python 3 and add tests #4085

Merged
merged 12 commits into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@hawkowl
Copy link
Contributor

hawkowl commented Oct 24, 2018

No description provided.

@hawkowl hawkowl requested a review from matrix-org/synapse-core Oct 24, 2018

@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Oct 24, 2018

Does it really need to split into a new file?

@hawkowl

This comment has been minimized.

Copy link
Contributor Author

hawkowl commented Oct 24, 2018

yes it needs to be in the tree, because scripts/ is not a python package

@erikjohnston
Copy link
Member

erikjohnston left a comment

Code wise looks alright, I have no idea how this is going to work with the packaging?

hawkowl added some commits Oct 26, 2018

@hawkowl hawkowl merged commit 77d70a7 into develop Oct 26, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hawkowl hawkowl deleted the hawkowl/py3-registermatrix branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.