Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Docker image listen on ipv6 as well as ipv4 #4089

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
2 participants
@dekonnection
Copy link
Contributor

dekonnection commented Oct 25, 2018

Currently, the Docker image only listens on ipv4, making it unusable on ipv6-enabled setups.

This commit modifies the binding address from "0.0.0.0" to "::", so Synapse would listen on all addresses, ipv4 or ipv6 ones.
On ipv4-only setups, this has no undesired side-effect, everything works as previously, and synapse will listen on all ipv4 addresses.

@dekonnection dekonnection changed the title Make Docker image listening on ipv6 as well as ipv4 Make Docker image listen on ipv6 as well as ipv4 Oct 25, 2018

@richvdh richvdh changed the base branch from master to develop Oct 25, 2018

@richvdh richvdh changed the base branch from develop to master Oct 25, 2018

@richvdh richvdh changed the base branch from master to develop Oct 25, 2018

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Oct 25, 2018

please could you add a newsfile as per CONTRIBUTING.rst?

@dekonnection dekonnection force-pushed the dekonnection:master branch 2 times, most recently from e363396 to 8bb67a1 Oct 25, 2018

@dekonnection

This comment has been minimized.

Copy link
Contributor Author

dekonnection commented Oct 25, 2018

please could you add a newsfile as per CONTRIBUTING.rst?

Just added it :)

Sorry for missing that, first contribution here.

@@ -0,0 +1,4 @@
Currently, the Docker image only listens on ipv4, making it unusable on ipv6-enabled setups.

This comment has been minimized.

Copy link
@richvdh

richvdh Oct 25, 2018

Member

ok, sorry: this file is what ends up in the changelog, so needs to be a succinct one-line summary. see https://github.com/matrix-org/synapse/blob/master/CHANGES.md#synapse-0337rc1-2018-10-15 for some examples, but basically, you want something more like "Configure the Docker image to listen on IPv6 addresses".

I'm sorry the CONTRIBUTING.rst doesn't make that clearer :/

This comment has been minimized.

Copy link
@dekonnection

dekonnection Oct 25, 2018

Author Contributor

It's done :)

@dekonnection dekonnection force-pushed the dekonnection:master branch from 8bb67a1 to f3b1c49 Oct 25, 2018

Make Docker image listening on ipv6 as well as ipv4
Signed-off-by: Cédric Laudrel <dek@iono.me>

@dekonnection dekonnection force-pushed the dekonnection:master branch from f3b1c49 to 379376e Oct 25, 2018

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Oct 25, 2018

\o/ thank you!

@richvdh richvdh merged commit 6cb2e24 into matrix-org:develop Oct 25, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.