Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support m.login.sso #4220

Merged
merged 3 commits into from Nov 27, 2018

Conversation

2 participants
@richvdh
Copy link
Member

commented Nov 23, 2018

MSC1721 renames m.login.cas to m.login.sso. This implements the change (retaining support for m.login.cas for older clients).

There is also (in a separate commit) a refactorathon of the fallback login page and its CSS.

richvdh added some commits Nov 23, 2018

Clean up the CSS for the fallback login form
I was finding this hard to work with, so simplify a bunch of things. Each
flow is now a form inside a div of class login_flow.

The login_flow class now has a fixed width, as that looks much better than each
flow having a differnt width.
Support m.login.sso
MSC1721 renames m.login.cas to m.login.sso. This implements the change
(retaining support for m.login.cas for older clients).

@richvdh richvdh requested a review from matrix-org/synapse-core Nov 23, 2018

@richvdh

This comment has been minimized.

Copy link
Member Author

commented Nov 23, 2018

Test updates in matrix-org/sytest#528

@hawkowl hawkowl merged commit 944d524 into develop Nov 27, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Superceded by https://github.com/orgs/matrix-org/projects/8 automation moved this from Review to Done - Operations Nov 27, 2018

@hawkowl hawkowl deleted the rav/sso_login branch Nov 27, 2018

@zauguin zauguin referenced this pull request Feb 4, 2019

Merged

Avoid redundant URL encoding #4555

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.