New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a GC after each test to fix logcontext leaks #4227

Merged
merged 3 commits into from Nov 27, 2018

Conversation

3 participants
@richvdh
Member

richvdh commented Nov 26, 2018

This replaces an earlier attempt to fix these leaks on #4213.

This feels like an awful hack, but perhaps it's the least bad option

@richvdh richvdh added this to To Do in Backend Core Team via automation Nov 26, 2018

@richvdh richvdh requested a review from matrix-org/synapse-core Nov 26, 2018

@richvdh richvdh moved this from To Do to Review in Backend Core Team Nov 26, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 26, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (develop@e8690de). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4227   +/-   ##
==========================================
  Coverage           ?   66.65%           
==========================================
  Files              ?      299           
  Lines              ?    29796           
  Branches           ?     4871           
==========================================
  Hits               ?    19860           
  Misses             ?     8501           
  Partials           ?     1435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8690de...eb33f7f. Read the comment docs.

@hawkowl hawkowl merged commit de8772a into develop Nov 27, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Backend Core Team automation moved this from Review to Done - Operations Nov 27, 2018

@hawkowl hawkowl deleted the rav/gc_after_test branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment