New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable search for homeservers which may not be interested in it #4230

Merged
merged 4 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@turt2live
Copy link
Member

turt2live commented Nov 27, 2018

This is useful for homeservers not intended for users, such as bot-only homeservers or ones that only process IoT data.

This was done with a community hat on:
Signed-off-by: Travis Ralston travis@t2bot.io

turt2live added some commits Nov 27, 2018

Add an option to disable search for homeservers which may not be inte…
…rested in it

This is useful for homeservers not intended for users, such as bot-only homeservers or ones that only process IoT data.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #4230 into develop will increase coverage by 6.87%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4230      +/-   ##
===========================================
+ Coverage    66.65%   73.52%   +6.87%     
===========================================
  Files          299      299              
  Lines        29796    29813      +17     
  Branches      4871     4875       +4     
===========================================
+ Hits         19861    21921    +2060     
+ Misses        8501     6460    -2041     
+ Partials      1434     1432       -2
Impacted Files Coverage Δ
synapse/storage/search.py 62.03% <0%> (-0.95%) ⬇️
synapse/handlers/search.py 80.24% <0%> (+2.74%) ⬆️
synapse/config/server.py 63.88% <100%> (+6.87%) ⬆️
synapse/handlers/federation.py 61.72% <0%> (+0.1%) ⬆️
synapse/handlers/user_directory.py 70.73% <0%> (+0.3%) ⬆️
synapse/handlers/sync.py 92.05% <0%> (+0.44%) ⬆️
synapse/rest/client/v1/room.py 92.75% <0%> (+0.5%) ⬆️
synapse/rest/client/v1/presence.py 65.95% <0%> (+1.06%) ⬆️
synapse/push/httppusher.py 68.23% <0%> (+1.17%) ⬆️
synapse/handlers/directory.py 73.12% <0%> (+1.25%) ⬆️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44c0a0...7c1e82f. Read the comment docs.

Show resolved Hide resolved synapse/storage/search.py Outdated

turt2live added some commits Nov 28, 2018

@richvdh

richvdh approved these changes Dec 4, 2018

Copy link
Member

richvdh left a comment

lgtm

@richvdh richvdh merged commit 158ffb9 into develop Dec 4, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@turt2live turt2live deleted the travis/disable-search branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment