New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more detail to logging regarding "More than one row matched" error #4234

Merged
merged 3 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@benparsons
Copy link
Member

benparsons commented Nov 28, 2018

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #4234 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4234      +/-   ##
===========================================
- Coverage    73.55%   73.54%   -0.01%     
===========================================
  Files          299      299              
  Lines        29806    29806              
  Branches      4872     4872              
===========================================
- Hits         21923    21921       -2     
+ Misses        6456     6454       -2     
- Partials      1427     1431       +4
Impacted Files Coverage Δ
synapse/state/v1.py 90.69% <0%> (-1.56%) ⬇️
synapse/handlers/user_directory.py 70.73% <0%> (-0.31%) ⬇️
synapse/handlers/search.py 81.25% <0%> (ø) ⬆️
synapse/handlers/federation.py 61.72% <0%> (ø) ⬆️
synapse/app/homeserver.py 57.28% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7039ece...380d544. Read the comment docs.

@@ -849,9 +849,9 @@ def _simple_update_one_txn(cls, txn, table, keyvalues, updatevalues):
rowcount = cls._simple_update_txn(txn, table, keyvalues, updatevalues)

if rowcount == 0:
raise StoreError(404, "No row found")
raise StoreError(404, "No row found (%s)" % table)

This comment has been minimized.

@hawkowl

hawkowl Dec 3, 2018

Contributor

The syntax here should be "No row found (%s)" % (table,)

@richvdh

richvdh approved these changes Dec 4, 2018

@richvdh richvdh merged commit b5ac0ff into develop Dec 4, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benparsons benparsons deleted the benp/more-than-one-row-matched-logging branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment