New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop sent_transactions #4244

Merged
merged 2 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@aaronraimist
Contributor

aaronraimist commented Dec 2, 2018

Fixes #2930 (maybe, I have no idea what I'm doing 馃槄)

aaronraimist added some commits Dec 2, 2018

Drop sent_transactions
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Add changelog
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@codecov-io

This comment has been minimized.

codecov-io commented Dec 2, 2018

Codecov Report

Merging #4244 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4244      +/-   ##
===========================================
- Coverage    73.55%   73.54%   -0.01%     
===========================================
  Files          299      298       -1     
  Lines        29806    29796      -10     
  Branches      4872     4871       -1     
===========================================
- Hits         21923    21913      -10     
+ Misses        6456     6453       -3     
- Partials      1427     1430       +3
Impacted Files Coverage 螖
synapse/storage/prepare_database.py 74.67% <100%> (酶) 猬嗭笍
synapse/util/file_consumer.py 80.7% <0%> (-1.76%) 猬囷笍
synapse/handlers/search.py 81.25% <0%> (酶) 猬嗭笍
synapse/handlers/federation.py 61.72% <0%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 7039ece...44dc4c3. Read the comment docs.

@richvdh

richvdh approved these changes Dec 4, 2018

Member

richvdh left a comment

Yup so this lgtm. I've added a few notes below for future reference but none of them are big enough concerns for me to hold this back.

@@ -25,7 +25,7 @@

# Remember to update this number every time a change is made to database
# schema files, so the users will be informed on server restarts.
SCHEMA_VERSION = 52
SCHEMA_VERSION = 53

This comment has been minimized.

@richvdh

richvdh Dec 4, 2018

Member

It's not always necessary to bump this - you can just keep adding more delta files into the current delta directory.

@@ -1,4 +1,4 @@
/* Copyright 2015, 2016 OpenMarket Ltd
/* Copyright 2018 New Vector Ltd

This comment has been minimized.

@richvdh

richvdh Dec 4, 2018

Member

New Vector didn't write it, so this isn't really true.

You wrote it (all six words of it), so it's copyright yourself (with a license for us to use it via the DCO), either implicitly or explicitly. So either: Copyright 2018 Aaron Raimist, or just omit it.

DROP TABLE IF EXISTS sent_transactions;

This comment has been minimized.

@richvdh

richvdh Dec 4, 2018

Member

It would be useful to have a comment here explaining why this is a useful thing to do and some of the history

@richvdh

This comment has been minimized.

Member

richvdh commented Dec 4, 2018

(thanks!)

@richvdh richvdh merged commit f144c0a into matrix-org:develop Dec 4, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment