New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing pushers on python 3 #4250

Merged
merged 2 commits into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@hawkowl
Copy link
Contributor

hawkowl commented Dec 3, 2018

No description provided.

hawkowl added some commits Dec 3, 2018

@hawkowl hawkowl requested a review from matrix-org/synapse-core Dec 3, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 3, 2018

Codecov Report

Merging #4250 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4250      +/-   ##
===========================================
- Coverage    73.55%   73.54%   -0.01%     
===========================================
  Files          299      299              
  Lines        29806    29806              
  Branches      4872     4872              
===========================================
- Hits         21923    21921       -2     
  Misses        6456     6456              
- Partials      1427     1429       +2
Impacted Files Coverage Δ
synapse/rest/client/v1/pusher.py 71.76% <100%> (ø) ⬆️
synapse/util/file_consumer.py 80.7% <0%> (-1.76%) ⬇️
synapse/handlers/user_directory.py 70.73% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c033242...998ba41. Read the comment docs.

@richvdh

richvdh approved these changes Dec 4, 2018

Copy link
Member

richvdh left a comment

lgtm.

For future reference: what were the symptoms of the bug? The text of the exception would be useful for searches.

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Dec 4, 2018

This is actually fixing #4222 aiui.

@richvdh richvdh merged commit a077e71 into develop Dec 4, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment