New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes on upgrading to python3, and README updates. #4260

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@richvdh
Copy link
Member

richvdh commented Dec 4, 2018

No description provided.

@erikjohnston
Copy link
Member

erikjohnston left a comment

What's the rationale on changing the virtualenv directories?

virtualenv -p python2.7 ~/.synapse
source ~/.synapse/bin/activate
mkdir -p ~/synapse
virtualenv -p python3 ~/synapse/env

This comment has been minimized.

@erikjohnston

erikjohnston Dec 4, 2018

Member

Does python3 recommend using the venv module?

This comment has been minimized.

@richvdh

richvdh Dec 4, 2018

Member

I'm unfamiliar with the venv module.

This comment has been minimized.

@erikjohnston

erikjohnston Dec 4, 2018

Member

Its a standard library equivalent to virtualenv, but probably fine to stick with virtualenv for now

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Dec 4, 2018

What's the rationale on changing the virtualenv directories?

It always struck me that putting them in a hidden directory was odd, and I don't know why we recommend it. I thought I'd clean it up while we were here.

@erikjohnston

This comment has been minimized.

Copy link
Member

erikjohnston commented Dec 4, 2018

What's the rationale on changing the virtualenv directories?

It always struck me that putting them in a hidden directory was odd, and I don't know why we recommend it. I thought I'd clean it up while we were here.

Its a bit rude to be adding bits directly to the home directory, but eh, I guess if people care then they can change it when following the instructions

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 4, 2018

Codecov Report

Merging #4260 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4260      +/-   ##
===========================================
+ Coverage    73.51%   73.52%   +0.01%     
===========================================
  Files          298      298              
  Lines        29819    29819              
  Branches      4881     4881              
===========================================
+ Hits         21921    21925       +4     
+ Misses        6460     6458       -2     
+ Partials      1438     1436       -2
Impacted Files Coverage Δ
synapse/app/homeserver.py 57.28% <0%> (+0.33%) ⬆️
synapse/state/v1.py 92.24% <0%> (+1.55%) ⬆️
synapse/util/file_consumer.py 82.45% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b164241...4acd1a3. Read the comment docs.

@richvdh richvdh merged commit a2ed0f2 into develop Dec 4, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the rav/python3 branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment