Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash on pagination. #4263

Merged
merged 1 commit into from Feb 21, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+2 −1
Diff settings

Always

Just for now

Copy path View file
@@ -0,0 +1 @@
Prevent crash on pagination.

This comment has been minimized.

Copy link
@richvdh

richvdh Feb 27, 2019

Member

@erikjohnston please can we not use the word "crash" when we mean "throw an exception". "crash" sounds like the whole process dies.

@@ -253,7 +253,7 @@ def get_messages(self, requester, room_id=None, pagin_config=None,
)

state = None
if event_filter and event_filter.lazy_load_members():
if event_filter and event_filter.lazy_load_members() and len(events) > 0:
# TODO: remove redundant members

# FIXME: we also care about invite targets etc.
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.