Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'sandbox' to CSP for media repo #4284

merged 2 commits into from Dec 10, 2018


None yet
3 participants
Copy link

commented Dec 10, 2018

No description provided.

dbkr added some commits Dec 10, 2018


This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2018

nope, messed up my branches :(

@dbkr dbkr closed this Dec 10, 2018

@dbkr dbkr reopened this Dec 10, 2018

@dbkr dbkr changed the base branch from release-v0.34.0 to develop Dec 10, 2018

turt2live added a commit to turt2live/matrix-media-repo that referenced this pull request Dec 10, 2018


This comment has been minimized.

Copy link
Member Author

commented Dec 10, 2018

OK, better


This comment has been minimized.

Copy link

commented Dec 10, 2018

Codecov Report

Merging #4284 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4284      +/-   ##
- Coverage    73.52%   73.48%   -0.04%     
  Files          302      302              
  Lines        29892    29892              
  Branches      4887     4887              
- Hits         21977    21966      -11     
- Misses        6479     6491      +12     
+ Partials      1436     1435       -1
Impacted Files Coverage Δ
synapse/rest/media/v1/ 100% <ø> (ø) ⬆️
synapse/http/ 85.08% <0%> (-2.83%) ⬇️
synapse/federation/ 70.79% <0%> (-0.83%) ⬇️
synapse/app/ 56.53% <0%> (-0.33%) ⬇️
synapse/handlers/ 80.24% <0%> (ø) ⬆️
synapse/handlers/ 61.72% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 989f116...4239bd2. Read the comment docs.

@hawkowl hawkowl merged commit 89ac2a5 into develop Dec 10, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
continuous-integration/travis-ci/pr The Travis CI build passed

@hawkowl hawkowl deleted the dbkr/add_sandbox_to_csp branch Dec 10, 2018

richvdh added a commit that referenced this pull request Dec 20, 2018

Add 'sandbox' to CSP for media repo (#4284)
* Add 'sandbox' to the CSP for media repo

* Changelog

richvdh added a commit that referenced this pull request Jan 8, 2019

Merge tag 'v0.34.1rc1' into matrix-org-hotfixes
Synapse 0.34.1rc1 (2019-01-08)


- Special-case a support user for use in verifying behaviour of a given server. The support user does not appear in user directory or monthly active user counts. ([\#4141](#4141), [\#4344](#4344))
- Support for serving .well-known files ([\#4262](#4262))
- Rework SAML2 authentication ([\#4265](#4265), [\#4267](#4267))
- SAML2 authentication: Initialise user display name from SAML2 data ([\#4272](#4272))
- Synapse can now have its conditional/extra dependencies installed by pip. This functionality can be used by using `pip install matrix-synapse[feature]`, where feature is a comma separated list with the possible values `email.enable_notifs`, `matrix-synapse-ldap3`, `postgres`, `resources.consent`, `saml2`, `url_preview`, and `test`. If you want to install all optional dependencies, you can use "all" instead. ([\#4298](#4298), [\#4325](#4325), [\#4327](#4327))
- Add routes for reading account data. ([\#4303](#4303))
- Add opt-in support for v2 rooms ([\#4307](#4307))
- Add a script to generate a clean config file ([\#4315](#4315))
- Return server data in /login response ([\#4319](#4319))


- Fix contains_url check to be consistent with other instances in code-base and check that value is an instance of string. ([\#3405](#3405))
- Fix CAS login when username is not valid in an MXID ([\#4264](#4264))
- Send CORS headers for /media/config ([\#4279](#4279))
- Add 'sandbox' to CSP for media reprository ([\#4284](#4284))
- Make the new landing page prettier. ([\#4294](#4294))
- Fix deleting E2E room keys when using old SQLite versions. ([\#4295](#4295))
- The metric synapse_admin_mau:current previously did not update when config.mau_stats_only was set to True ([\#4305](#4305))
- Fixed per-room account data filters ([\#4309](#4309))
- Fix indentation in default config ([\#4313](#4313))
- Fix synapse:latest docker upload ([\#4316](#4316))
- Fix compatibility with prometheus_client 0.5. Contributed by Maarten de Vries <>. ([\#4317](#4317))
- Avoid packaging _trial_temp directory in -py3 debian packages ([\#4326](#4326))
- Check jinja version for consent resource ([\#4327](#4327))
- fix NPE in /messages by checking if all events were filtered out ([\#4330](#4330))
- Fix `python -m synapse.config` on Python 3. ([\#4356](#4356))

Deprecations and Removals

- Remove the deprecated v1/register API on Python 2. It was never ported to Python 3. ([\#4334](#4334))

Internal Changes

- Getting URL previews of IP addresses no longer fails on Python 3. ([\#4215](#4215))
- drop undocumented dependency on dateutil ([\#4266](#4266))
- Update the example systemd config to use a virtualenv ([\#4273](#4273))
- Update link to kernel DCO guide ([\#4274](#4274))
- Make isort tox check print diff when it fails ([\#4283](#4283))
- Log room_id in Unknown room errors ([\#4297](#4297))
- Documentation improvements for coturn setup. Contributed by Krithin Sitaram. ([\#4333](#4333))
- Update pull request template to use absolute links ([\#4341](#4341))
- Update README to not lie about required restart when updating TLS certificates ([\#4343](#4343))
- Update debian packaging for compatibility with transitional package ([\#4349](#4349))
- Fix command hint to generate a config file when trying to start without a config file ([\#4353](#4353))
- Add better logging for unexpected errors while sending transactions ([\#4358](#4358))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.