New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a welcome page to the static resources #4289

Merged
merged 3 commits into from Dec 11, 2018

Conversation

3 participants
@richvdh
Copy link
Member

richvdh commented Dec 11, 2018

This is largely a precursor for the removal of the bundled webclient. The idea is to present a page at / which reassures people that something is working, and to give them some links for next steps.

The welcome page lives at /_matrix/static/, so is enabled alongside the other static resources (which, in practice, means the client API is enabled). We'll redirect to it from / if we have nothing better to display there.

It would be nice to have a way to disable it (in the same way that you might disable the nginx welcome page), but I can't really think of a good way to do that without a load of ickiness.

It's based on the work done by @krombel for #2601.

@richvdh richvdh requested a review from matrix-org/synapse-core Dec 11, 2018

@erikjohnston
Copy link
Member

erikjohnston left a comment

Other than circleci seems to be sad

Add a welcome page to the static resources
This is largely a precursor for the removal of the bundled webclient. The idea
is to present a page at / which reassures people that something is working, and
to give them some links for next steps.

The welcome page lives at `/_matrix/static/`, so is enabled alongside the other
`static` resources (which, in practice, means the client API is enabled). We'll
redirect to it from `/` if we have nothing better to display there.

It would be nice to have a way to disable it (in the same way that you might
disable the nginx welcome page), but I can't really think of a good way to do
that without a load of ickiness.

It's based on the work done by @krombel for #2601.

@richvdh richvdh force-pushed the rav/welcome_page branch from f516276 to f537432 Dec 11, 2018

richvdh added some commits Dec 11, 2018

Disable pager for ci script
... otherwise it hangs

@richvdh richvdh added this to To Do in Backend Core Team via automation Dec 11, 2018

@richvdh richvdh changed the base branch from develop to release-v0.34.0 Dec 11, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 11, 2018

Codecov Report

Merging #4289 into release-v0.34.0 will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-v0.34.0    #4289      +/-   ##
===================================================
- Coverage            73.52%   73.48%   -0.05%     
===================================================
  Files                  298      302       +4     
  Lines                29819    29894      +75     
  Branches              4881     4888       +7     
===================================================
+ Hits                 21925    21968      +43     
- Misses                6458     6488      +30     
- Partials              1436     1438       +2
Impacted Files Coverage Δ
synapse/app/homeserver.py 56.16% <0%> (-0.79%) ⬇️
synapse/util/versionstring.py 67.64% <0%> (-2.95%) ⬇️
synapse/handlers/auth.py 70.95% <0%> (ø) ⬆️
synapse/python_dependencies.py 40.9% <0%> (ø) ⬆️
synapse/rest/media/v1/download_resource.py 100% <0%> (ø) ⬆️
synapse/config/saml2.py
synapse/rest/saml2/__init__.py 0% <0%> (ø)
synapse/rest/well_known.py 96.42% <0%> (ø)
synapse/rest/saml2/metadata_resource.py 0% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dece89d...bd52978. Read the comment docs.

@richvdh richvdh merged commit 95c1f65 into release-v0.34.0 Dec 11, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Backend Core Team automation moved this from To Do to Done - Operations Dec 11, 2018

@nadonomy nadonomy referenced this pull request Dec 13, 2018

Merged

Improved welcome page #4294

@richvdh richvdh deleted the rav/welcome_page branch Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment